Fix for null JVMTI pointer in compileModule
#381
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes a crash in compileModule() when JVMTI is unavailable (e.g., missing EnsurePluginLoaded), which previously resulted in Error: expected a pointer.
Changes:
- Writes a null pointer (
ptr(0)) instead ofnullwhenapi.jvmtiis unavailable, preventingwritePointer(null)from throwing.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| let j = javaApi; | ||
| [ | ||
| jvmti, | ||
| jvmti !== null ? jvmti : ptr(0), |
There was a problem hiding this comment.
jvmti !== null ? jvmti : ptr(0) only guards the null case. On Dalvik, android.getApi() doesn't define jvmti at all (so it will be undefined), which would still be passed into writePointer() and can throw Error: expected a pointer. Consider using a nullish check (treating both null and undefined as absent) and defaulting to a null pointer (NULL/ptr(0)).
There was a problem hiding this comment.
Fix with jvmti ?? ptr(0)?
But I'm not sure about jvmti being undefined instead of null on Dalvik devices 🤔
1 participant
Fixes crash
Error: expected a pointerin v7.0.11 when JVMTI is unavailable on some Android devices.Fixed #380